Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open release/quince.3 #400

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Open release/quince.3 #400

wants to merge 7 commits into from

Conversation

mananvyas-123
Copy link

TL;DR - [ A short summary of what this PR does and why ]

JIRA: JIRA-XXXX

What changed?

  • [ More in depth breakdown of changes ]
  • [ Peripheral things that got changed ]
  • [ etc... ]

Developer Checklist

  • Test suites passing
  • Documentation and test plan updated, if applicable
  • Received code-owner approving review
  • Bumped version number package.json

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@Syed-Ali-Abbas-Zaidi
chore: bump frontend-platform (openedx#356)
b536180
@ihor-romaniuk
fix: fix sidebar scrolling and adaptation for mobile
f303712 
- fix text overload in heading
- fix appearance for sidebar with a short main content
- fix transformation of search and filter button on mobile
- fix extra empty space below main content table
- fix adaptation modal content to mobile view
@arbrandes
fix: Route with PUBLIC_PATH
ba9fb37 
Prior to this change, the MFE would fail to render with any PUBLIC_PATH
set.  Because that is now handled entirely by `frontend-platform`, we
can avoid referring to PUBLIC_PATH entirely, here.
@arbrandes
Merge pull request openedx#376 from arbrandes/fix-route-quince
acdad5a 
[Quince backport] fix: Route with PUBLIC_PATH
fix: "An unexpected error occurred" after second opening any grade
bd25b6b
@arbrandes
Merge pull request openedx#370 from raccoongang/fix/fix-responsive-is…
e795163 
…sues-quince

fix: fix sidebar scrolling and adaptation for mobile
@cmltaWt0
Merge pull request openedx#386 from DmytroAlipov/fix-second-opening-g…
aa2b1a5 
…rade-quince

fix: "An unexpected error occurred" after second opening any grade
@mananvyas-123 mananvyas-123 requested a review from a team as a code owner July 25, 2024 09:31
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 25, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @mananvyas-123!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @farhaanbukhsh. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211
Copy link

Hi @mananvyas-123! Thanks for this contribution. Would you please add a description of your changes to the top of the pull request?

Please also let me know if you have any questions regarding submitting a CLA form. Thanks!

@mphilbrick211 mphilbrick211 removed the request for review from a team July 25, 2024 21:09
@mphilbrick211
Copy link

Hi @mananvyas-123! Just checking to see if you plan to pursue this pull request?

@mphilbrick211 mphilbrick211 added the inactive PR author has been unresponsive for several months label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
inactive PR author has been unresponsive for several months open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Needs Tests Run or CLA Signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mananvyas-123 @openedx-webhooks @mphilbrick211 @Syed-Ali-Abbas-Zaidi @ihor-romaniuk @arbrandes @cmltaWt0